bgpv2: relax mandatory PeerASN field in BGP peer configuration #35817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit d1192e6 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
d1192e6 to
3e0009c
Compare
rastislavs
approved these changes
Nov 6, 2024
3e0009c to
c3567ca
Compare
YutaroHayakawa
requested changes
Nov 7, 2024
c3567ca to
8a4cd12
Compare
|
/test |
YutaroHayakawa
approved these changes
Nov 8, 2024
nathanjsweet
approved these changes
Nov 11, 2024
Users can decide to omit PeerASN field, in which case underlying implementation will not do ASN validation and set peer ASN based on BGP OPEN message from the peer. Peering will be established and runtime state like BGP CLI or CiliumBGPNodeConfig CRD status will reflect peer ASN. Signed-off-by: harsimran pabla <hpabla@isovalent.com>
8a4cd12 to
b01b0c5
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can decide to omit PeerASN field, in which case underlying implementation will not do ASN validation in BGP OPEN state. Once peering is established and runtime state like BGP CLI or CiliumBGPNodeConfig CRD status will reflect peer ASN.
Now if user does not specify PeerASN, 0 will be passed to Cilium BGP Control Plane.