Skip to content

Conversation

jrajahalme
Copy link
Member

Add Helm option 'envoy.initialFetchTimeoutSeconds' and Cilium CLI option 'proxy-initial-fetch-timeout' (seconds), defaulting to 30 seconds. Envoy default is 15 seconds, which may go by while we wait for the endpoints to have regenerated during restart.

This can be used to avoid Envoy warning logs when the initial fetch is expected to take longer as we wait for the endpoints to regenerate.

Fixes: #32824

Added Helm option 'envoy.initialFetchTimeoutSeconds' (default 30 seconds) to override the Envoy default (15 seconds).

@jrajahalme jrajahalme added kind/enhancement This would improve or streamline existing functionality. area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Nov 6, 2024
@jrajahalme jrajahalme requested review from a team as code owners November 6, 2024 13:05
@jrajahalme jrajahalme added needs-backport/1.14 needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Nov 6, 2024
@jrajahalme jrajahalme mentioned this pull request Nov 6, 2024
@jrajahalme jrajahalme added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 labels Nov 6, 2024
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice findings 👍

@jrajahalme jrajahalme mentioned this pull request Nov 6, 2024
@jrajahalme jrajahalme added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 labels Nov 6, 2024
@jrajahalme jrajahalme force-pushed the envoy-initial-fetch-timeout branch from c606573 to d619817 Compare November 6, 2024 13:38
@jrajahalme
Copy link
Member Author

/test

Add Helm option 'envoy.initialFetchTimeoutSeconds' and Cilium CLI option
'proxy-initial-fetch-timeout' (seconds), defaulting to 30 seconds.
Envoy default is 15 seconds, which may go by while we wait for the
endpoints to have regenerated during restart.

Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jrajahalme jrajahalme force-pushed the envoy-initial-fetch-timeout branch from d619817 to 2fc49ef Compare November 6, 2024 13:46
@jrajahalme
Copy link
Member Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 6, 2024
@jrajahalme jrajahalme added this pull request to the merge queue Nov 6, 2024
Merged via the queue into cilium:main with commit 8272fd1 Nov 6, 2024
64 checks passed
@jrajahalme jrajahalme deleted the envoy-initial-fetch-timeout branch November 6, 2024 18:57
@jrajahalme jrajahalme added needs-backport/1.14 and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. needs-backport/1.14 labels Nov 7, 2024
@viktor-kurchenko viktor-kurchenko mentioned this pull request Nov 12, 2024
13 tasks
@viktor-kurchenko viktor-kurchenko added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Nov 12, 2024
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants