-
Notifications
You must be signed in to change notification settings - Fork 3.4k
envoy: Add configurable initial fetch timeout #35809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sayboras
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice findings 👍
Closed
squeed
approved these changes
Nov 6, 2024
c606573
to
d619817
Compare
/test |
Add Helm option 'envoy.initialFetchTimeoutSeconds' and Cilium CLI option 'proxy-initial-fetch-timeout' (seconds), defaulting to 30 seconds. Envoy default is 15 seconds, which may go by while we wait for the endpoints to have regenerated during restart. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
d619817
to
2fc49ef
Compare
/test |
nathanjsweet
approved these changes
Nov 6, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/proxy
Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers.
backport-done/1.16
The backport for Cilium 1.16.x for this PR is done.
kind/enhancement
This would improve or streamline existing functionality.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/minor
This PR changes functionality that users may find relevant to operating Cilium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Helm option 'envoy.initialFetchTimeoutSeconds' and Cilium CLI option 'proxy-initial-fetch-timeout' (seconds), defaulting to 30 seconds. Envoy default is 15 seconds, which may go by while we wait for the endpoints to have regenerated during restart.
This can be used to avoid Envoy warning logs when the initial fetch is expected to take longer as we wait for the endpoints to regenerate.
Fixes: #32824