Skip to content

ci: add watch request thresholds #35808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2024
Merged

ci: add watch request thresholds #35808

merged 1 commit into from
Nov 7, 2024

Conversation

marseel
Copy link
Contributor

@marseel marseel commented Nov 6, 2024 •
edited
Loading

Related: #35797

To prevent regressions with interactions with k8s apiserver, let's introduce checks to ensure we are not duplicating watchers to k8s apiservers.

Example output from run https://github.com/cilium/cilium/actions/runs/11703820585/job/32594959446:

metric: Watch request thresholds: Services, value: 317, threshold: 320 (upper bound)
metric: Watch request thresholds: Endpoints, value: 2, threshold: 10 (upper bound)
metric: Watch request thresholds: EndpointSlices, value: 212, threshold: 220 (upper bound)
metric: Watch request thresholds: Pods, value: 212, threshold: 220 (upper bound)
metric: Watch request thresholds: CCNPs, value: 105, threshold: 120 (upper bound)
metric: Watch request thresholds: CNPs, value: 105, threshold: 120 (upper bound)
metric: Watch request thresholds: NetworkPolicies, value: 103, threshold: 120 (upper bound)
metric: Watch request thresholds: Namespaces, value: 115, threshold: 120 (upper bound)
metric: Watch request thresholds: CiliumIdentities, value: 104, threshold: 120 (upper bound)
metric: Watch request thresholds: CiliumCIDRGroups, value: 103, threshold: 120 (upper bound)
metric: Watch request thresholds: CiliumEndpointsAndSlices, value: 105, threshold: 120 (upper bound)
metric: Watch request thresholds: CiliumNodes, value: 105, threshold: 120 (upper bound)

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 6, 2024
@marseel marseel added sig/scalability Impacts how well Cilium handles a high rate of events or churn. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 6, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 6, 2024
@marseel marseel added release-note/ci This PR makes changes to the CI. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 6, 2024
@marseel
Copy link
Contributor Author

marseel commented Nov 6, 2024

/scale-100

@marseel marseel force-pushed the pr/marseel/add_watch_calls_thresholds branch from 7023fea to 59a8cfc Compare November 6, 2024 12:37
@marseel
Copy link
Contributor Author

marseel commented Nov 6, 2024

/scale-100

@marseel
Copy link
Contributor Author

marseel commented Nov 6, 2024

/test

@marseel marseel requested a review from giorio94 November 6, 2024 13:23
@marseel marseel marked this pull request as ready for review November 6, 2024 13:23
@marseel marseel requested a review from a team as a code owner November 6, 2024 13:23
giorio94
giorio94 approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a couple of nits inline.

@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Nov 6, 2024
@marseel
ci: add watch request thresholds
aca82eb 
Related: #35797

To prevent regressions with interactions with k8s apiserver, let's
introduce checks to ensure we are not duplicating watchers to k8s
apiservers.

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@marseel marseel force-pushed the pr/marseel/add_watch_calls_thresholds branch from 59a8cfc to aca82eb Compare November 7, 2024 08:38
@marseel
Copy link
Contributor Author

marseel commented Nov 7, 2024

/test

@julianwiedmann julianwiedmann added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit 18a48ee Nov 7, 2024
268 of 269 checks passed
@julianwiedmann julianwiedmann deleted the pr/marseel/add_watch_calls_thresholds branch November 7, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giorio94 giorio94 giorio94 approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI. sig/scalability Impacts how well Cilium handles a high rate of events or churn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marseel @giorio94 @julianwiedmann