node: avoid JSON unserializable log field #35894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 11, 2024
|
/test |
joamaki
approved these changes
Nov 12, 2024
When setting logging up in such a way that logrus would attempt to
serialise entries to JSON, it could fail with errors such as:
Failed to obtain reader, failed to marshal fields to JSON, json: unsupported type: map[types.Identity]*types.Node
Replace the broken Info log with logging just the number of deleted
nodes and prepare a serializable slice of strings for the debug log with
more detail.
Fixes: b855b25 (node/manager: synthesize node deletion events)
Reported-by: Simon Dickhoven <sdickhoven@everquote.com>
Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
6500f09 to
ac60c80
Compare
|
/test (rebased due to #35889 linter fix getting merged) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting logging up in such a way that logrus would attempt to serialise entries to JSON, it could fail with errors such as:
Replace the broken Info log with logging just the number of deleted nodes and prepare a serializable slice of strings for the debug log with more detail.
Fixes: b855b25 (node/manager: synthesize node deletion events)