[v1.15] .github: Fix missing variable escaping in LVH command #35893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue with the tests-e2e-upgrade workflow where the
`${EXTRA{@}}` arguments were actually empty, because commands are bash
expanded on the host runner, i.e. before they are passed to the LVH VM. As a
result, the additional arguments were ignored.
This fix is only applied to v1.15 because other branches use different
methods for passing in `cilium connectivity check` command.
Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
|
/test-backport-1.15 |
brlbil
approved these changes
Nov 12, 2024
gandro
added a commit
that referenced
this pull request
Nov 13, 2024
PR #35893 fixed an escaping issue in that workflow but it seems like the correct escaping (which made `--secondary-network` work again) seem to have exposed an underlying issue with that configuration where it started failing in `north-south-loadbalancing-with-l7-policy` (#35967). In v1.16, we seemed to have fixed that problem in commit 1c42d6f, but in v1.15 running a different kernel version breaks the workflow. Therefore, this commit reverts the test back to not using a secondary network which is what it was effectively running previously. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
added a commit
that referenced
this pull request
Nov 13, 2024
PR #35893 fixed an escaping issue in that workflow but it seems like the correct escaping (which made `--secondary-network` work again) seem to have exposed an underlying issue with that configuration where it started failing in `north-south-loadbalancing-with-l7-policy` (#35967). In v1.16, we seemed to have fixed that problem in commit 1c42d6f, but in v1.15 running a different kernel version breaks the workflow. Therefore, this commit reverts the test back to not using a secondary network which is what it was effectively running previously. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the tests-e2e-upgrade workflow where the
${EXTRA{@}}arguments were actually empty, because commands are bash expanded on the host runner, i.e. before they are passed to the LVH VM. As a result, the additional arguments were ignored.This fix is only applied to v1.15 because other branches use different methods for passing in
cilium connectivity checkcommand.