Skip to content

Conversation

rolinh
Copy link
Member

@rolinh rolinh commented Nov 11, 2024

Prior to this change, using hubble --version and hubble version would produce different results:

hubble --version # v1.16.3
hubble version   # 1.16.3

Ref: cilium/hubble#1613

hubble: consistently use v as prefix for the Hubble version

@rolinh rolinh added kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. sig/hubble hubble-cli PRs or GitHub issues related with hubble-cli needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Nov 11, 2024
@rolinh rolinh requested a review from a team as a code owner November 11, 2024 14:23
@rolinh rolinh requested a review from kaworu November 11, 2024 14:23
@github-actions github-actions bot added the hubble-cli-exclusive Only changes hubble-cli files. label Nov 11, 2024
@kaworu
Copy link
Member

kaworu commented Nov 13, 2024

/test

Prior to this change, using `hubble --version` and `hubble version`
would produce different results:

    hubble --version # v1.16.3
    hubble version   # 1.16.3

Ref: cilium/hubble#1613

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@rolinh rolinh force-pushed the pr/rolinh/hubble-consistent-version branch from 186de3f to 2ddd745 Compare November 15, 2024 14:36
@rolinh
Copy link
Member Author

rolinh commented Nov 15, 2024

/test

@rolinh rolinh enabled auto-merge November 15, 2024 14:37
@rolinh rolinh added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit b424bfd Nov 20, 2024
131 checks passed
@rolinh rolinh deleted the pr/rolinh/hubble-consistent-version branch November 20, 2024 18:28
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Nov 20, 2024
@nbusseneau nbusseneau mentioned this pull request Dec 1, 2024
8 tasks
@nbusseneau nbusseneau added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Dec 1, 2024
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. hubble-cli PRs or GitHub issues related with hubble-cli hubble-cli-exclusive Only changes hubble-cli files. kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants