endpoint: don't start DNS history trigger when parsing endpoint #35890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This trigger may be, well, triggered when reacting to a DNS request -- even when the agent is starting up. This could lead to a deadlock, as the datapath is not able to write the endpoint header file until the agent is started, but the agent cannot finish starting as the endpoint is locked. The fix for this is to remove the unnecessary trigger initialization on endpoint parsing; we will always start it on first regeneration. This catches a case missed in cilium#34059, which only fixed the new-endpoint case. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
|
/test |
|
I suspect this will fix #35080 |
3 tasks
tommyp1ckles
approved these changes
Nov 11, 2024
Merged
1 task
|
@aanm test-foo-bar (André is testing his GitHub mail notifications 😁) |
|
@aanm test-foo-bar-1 |
|
@aanm test-foo-bar-2 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This trigger may be, well, triggered when reacting to a DNS request -- even when the agent is starting up. This could lead to a deadlock, as the datapath is not able to write the endpoint header file until the agent is started, but the agent cannot finish starting as the endpoint is locked.
The fix for this is to remove the unnecessary trigger initialization on endpoint parsing; we will always start it on first regeneration.
This catches a case missed in #34059, which only fixed the new-endpoint case. That change moved trigger initialization in to endpoint regeneration and out of endpoint initialization. But it missed this line.