Skip to content

Conversation

sayboras
Copy link
Member

Relates: #35370

@maintainer-s-little-helper
Copy link

Commit c6e77fa does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 11, 2024
Relates: #35370
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/cmdref-sysdump branch from c6e77fa to 7a2ee87 Compare November 11, 2024 01:01
@maintainer-s-little-helper
Copy link

Commit c6e77fa does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@sayboras sayboras added release-note/misc This PR makes changes that have no direct user impact. and removed dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. labels Nov 11, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 11, 2024
@sayboras sayboras marked this pull request as ready for review November 11, 2024 01:04
@sayboras sayboras requested a review from joestringer November 11, 2024 01:04
@sayboras
Copy link
Member Author

Adding reviewer manually as we intentionally omit codeowner for /Documentation/cmdref/

@sayboras
Copy link
Member Author

/test

@sayboras sayboras requested a review from aanm November 12, 2024 08:12
@aanm aanm added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit 5ee89a9 Nov 12, 2024
63 checks passed
@aanm aanm deleted the pr/tammach/cmdref-sysdump branch November 12, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants