Skip to content

fix: SetBackends should always update frontends of the modified service #35864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix: SetBackends should always update frontends of the modified service #35864

merged 1 commit into from
Nov 8, 2024

Conversation

DamianSawicki
Copy link
Contributor

When SetBackends(txn, name, source, bes) received an empty slice bes of BackendParams, it failed to refresh frontends of the service specified by name. This omission is now fixed and a test for SetBackends() is added, which in particular covers this issue.

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 8, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Nov 8, 2024
@DamianSawicki
Copy link
Contributor Author

/cc @joamaki

I believe I've caught a bug in SetBackends, could you please have a look?

@DamianSawicki DamianSawicki marked this pull request as ready for review November 8, 2024 10:56
@DamianSawicki DamianSawicki requested a review from a team as a code owner November 8, 2024 10:56
@ovidiutirla
Copy link
Contributor

/test

joamaki
joamaki approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@joamaki joamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. The fix makes sense and thanks for adding the tests!

@DamianSawicki
Copy link
Contributor Author

Oops. The fix makes sense and thanks for adding the tests!

Glad to help 😊

CICD seems broken though, failing with

Run for image in cilium-ci operator-generic-ci hubble-relay-ci ; do
Error: The action 'Wait for images to be available' has timed out after 30 minutes.

@DamianSawicki
fix: SetBackends should always update service
338dcb3 
When SetBackends received an empty slice [bes] of BackendParams,
it failed to refresh frontends of the service specified by [name]. This
omission is now fixed and a test for SetBackends is added which in
particular covers this issue.

Fixes: 485331f
Signed-off-by: Damian Sawicki <dsawicki@google.com>
@ovidiutirla
Copy link
Contributor

/test

@DamianSawicki DamianSawicki mentioned this pull request Nov 8, 2024
Merged
8 tasks
@DamianSawicki
Copy link
Contributor Author

CICD seems broken though, failing with

Perhaps it was just flakiness or infra overload. In any case, everything is green now 🚀

@ovidiutirla ovidiutirla added the release-note/misc This PR makes changes that have no direct user impact. label Nov 8, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 8, 2024
@joestringer joestringer added this pull request to the merge queue Nov 8, 2024
Merged via the queue into cilium:main with commit 24414e4 Nov 8, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joamaki joamaki joamaki approved these changes

@ysksuzuki ysksuzuki ysksuzuki approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DamianSawicki @ovidiutirla @joamaki @ysksuzuki @joestringer