v1.16 Backports 2024-11-08 #35863
Merged
v1.16 Backports 2024-11-08 #35863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit aa45b34 ] Currently, we're not tracking the CiliumBGPNodeConfig changes. We must track it to recover from the nodeSelector conflict for example. Without tracking it, the scenario like the following is possible: 1. NodeA is reffered from ClusterConfigA and ClusterConfigB. Currently, ClusterConfigB "owns" the node. 2. ClusterConfigB changed the nodeSelector. NodeA is no longer selected by ClusterConfigB. 3. ClusterConfigA suppose to create a new NodeConfig for NodeA, but the reconciliation was not triggered because we're not watching the NodeConfig changes. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
|
/test-backport-1.16 |
michi-covalent
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author backport
Once this PR is merged, a GitHub action will update the labels of these PRs: