Add feature tracking in Cilium agent as prometheus metrics #35852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
4e286af to
2f59e38
Compare
|
/test |
2f59e38 to
9791863
Compare
|
/test |
joamaki
reviewed
Nov 12, 2024
joamaki
reviewed
Nov 12, 2024
joamaki
reviewed
Nov 12, 2024
joamaki
reviewed
Nov 12, 2024
Artyop
reviewed
Nov 12, 2024
This was referenced Dec 16, 2024
This was referenced Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lays the groundwork for tracking which features are being used in Cilium by representing them as metrics. After this PR is merged, additional PRs will follow to track more features.
Once all relevant features are being tracked, we'll gain insight into which features are being tested or left untested globally across our CI. In this initial phase, the PR will introduce summary tables (like the one below) to show which features are tested in each GitHub workflow.
Click here to summary example
F.A.Q.:
Why a single package with metrics?
As this provides a great value in our CI and since the
pkg/metrics/featuresis contained on its own package I'm planing to backport this to all branches.Why a gauges instead of counters?
With gauges promtool doesn't complain that some metrics don't end with
_totalwhich is the norm for counters.Where are the docs?
Oh that's right, I'll add them all on the last PR with the rest of the metrics. Thanks for asking, it's nice to know that people care about docs.
edit: the documentation was added in #36579
This is a huge PR! Do I need to review everything?
It could be worse but it's up to you. The first commit is the foundation, the commits in the middle is for each individual feature added so it's easier to reviewed per commit.