Skip to content

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Nov 4, 2024

Extend the clustermesh upgrade/downgrade workflow to additionally assert that no error logs are emitted, as already done in most other workflows. This check was previously missing from the explicit allow list.

Extend the clustermesh upgrade/downgrade workflow to additionally assert
that no error logs are emitted, as already done in most other workflows.
This check was previously missing from the explicit allow list.

Reported-by; Paul Chaignon <paul.chaignon@gmail.com>
Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 added area/CI Continuous Integration testing issue or flake area/clustermesh Relates to multi-cluster routing functionality in Cilium. release-note/ci This PR makes changes to the CI. labels Nov 4, 2024
@giorio94
Copy link
Member Author

giorio94 commented Nov 4, 2024

/test

@giorio94 giorio94 marked this pull request as ready for review November 4, 2024 13:40
@giorio94 giorio94 requested review from a team as code owners November 4, 2024 13:40
@giorio94 giorio94 requested review from jrajahalme and brlbil November 4, 2024 13:40
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 4, 2024
@jrajahalme jrajahalme added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 2e06a89 Nov 4, 2024
84 checks passed
@jrajahalme jrajahalme deleted the pr/giorio94/main/gha-clustermesh-upgrade-errors branch November 4, 2024 16:22
@giorio94 giorio94 added needs-backport/1.14 needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch and removed needs-backport/1.14 needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/clustermesh Relates to multi-cluster routing functionality in Cilium. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants