Skip to content

docs-fix-bgp-url #35725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2024
Merged

docs-fix-bgp-url #35725

merged 1 commit into from
Nov 4, 2024

Conversation

nvibert
Copy link
Contributor

@nvibert nvibert commented Nov 4, 2024 •
edited by qmonnet
Loading 

docs: Fix incorrect link to RFC 4271 for BGP control plane timers.

@nvibert
Fixed incorrect URL
0afcf7f 
Signed-off-by: Nico Vibert <nvibert@cisco.com>
@nvibert nvibert requested review from a team as code owners November 4, 2024 09:46
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 4, 2024
@qmonnet qmonnet added the release-note/misc This PR makes changes that have no direct user impact. label Nov 4, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 4, 2024
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/bgp Impacts the Border Gateway Protocol feature. needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Nov 4, 2024
@qmonnet
Copy link
Member

qmonnet commented Nov 4, 2024

/test

@qmonnet qmonnet added this pull request to the merge queue Nov 4, 2024
Merged via the queue into cilium:main with commit 3ecac71 Nov 4, 2024
69 checks passed
@qmonnet
Copy link
Member

qmonnet commented Nov 4, 2024

Woops, I thought “merge when ready” meant when all codeowner teams had approved, I forgot that GitHub needs only one owner. Sorry Pabla!

@harsimran-pabla
Copy link
Contributor

Ah no worries @qmonnet, change is good.

@joamaki joamaki mentioned this pull request Nov 5, 2024
Merged
23 tasks
@joamaki joamaki added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Nov 5, 2024
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Nov 7, 2024
@cilium-release-bot cilium-release-bot bot mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

@xmulligan xmulligan xmulligan approved these changes

@harsimran-pabla harsimran-pabla Awaiting requested review from harsimran-pabla harsimran-pabla is a code owner automatically assigned from cilium/sig-bgp

Assignees
No one assigned
Labels
area/bgp Impacts the Border Gateway Protocol feature. area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nvibert @qmonnet @harsimran-pabla @xmulligan @joamaki