cli/connectivity: Check for unexpected warning logs #35723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
047f9ab to
1040378
Compare
7451827 to
a68596e
Compare
57b2bb1 to
817e2cf
Compare
We check for error logs in both the CLI's connectivity tests and the ginkgo tests. Warning logs are however only checked by ginkgo tests since commit 551f435 ("test: Fail on level=warning logs"). This commit extends the CLI connectivity tests to also check for warning logs, with the same exception list as in ginkgo tests. Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
The "Unable to translate all CIDR groups to CIDRs" warning was removed in main, but it's still happening when the upgrade test runs v1.16. We can therefore remove that exception once the upgrade test covers v1.17<>v1.18. Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
817e2cf to
53e99e5
Compare
|
/test |
thorn3r
approved these changes
Nov 21, 2024
aspsk
approved these changes
Nov 21, 2024
tklauser
added a commit
to tklauser/hubble-ui
that referenced
this pull request
Nov 28, 2024
The cilium-cli connectivity test treats warnings in the logs as test errors[^1]. This causes tests involving hubble-ui to fail[^2]. As these fallbacks aren't really warnings but rather informative messsages, demote them to info level. [^1]: cilium/cilium#35723 [^2]: https://github.com/cilium/cilium-cli/actions/runs/12051244564/job/33601849065?pr=2869#step:13:541 Signed-off-by: Tobias Klauser <tobias@cilium.io>
yannikmesserli
pushed a commit
to cilium/hubble-ui
that referenced
this pull request
Jan 13, 2025
…ing (#940) The cilium-cli connectivity test treats warnings in the logs as test errors[^1]. This causes tests involving hubble-ui to fail[^2]. As these fallbacks aren't really warnings but rather informative messsages, demote them to info level. [^1]: cilium/cilium#35723 [^2]: https://github.com/cilium/cilium-cli/actions/runs/12051244564/job/33601849065?pr=2869#step:13:541 Signed-off-by: Tobias Klauser <tobias@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #35772.