watcher: Avoid using global default slog #35702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54166e1 to
6031f83
Compare
|
/test |
rastislavs
approved these changes
Nov 4, 2024
giorio94
approved these changes
Nov 4, 2024
pippolo84
approved these changes
Nov 4, 2024
|
Manually removing ready-to-merge label to give @sayboras a chance to address Marco's comments before merging. |
Thanks a lot 👍 |
As highlighted in below comment, the default logger is completely replaced (rather than being mutated) during the configuration phase, so we should avoid using global slog instance. Relates: #35567 Reported-by: Marco Iorio <marco.iorio@isovalent.com> Signed-off-by: Tam Mach <tam.mach@cilium.io>
6031f83 to
6be5b67
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As highlighted in below comment, the default logger is completely replaced (rather than being mutated) during the configuration phase, so we should avoid using global slog instance.
Relates: #35567
Reported-by: Marco Iorio marco.iorio@isovalent.com