Skip to content

daemon: Reduce level of socket LB tracing warning #35798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Nov 6, 2024

This warning is emitted when the kernel doesn't support socket-level LB tracing. That feature is however enabled by default and only kernels 5.7+ support it. That means this warning will be displayed by default to a lot of users.

This commit reduces the log level to Info to avoid that and to be consistent with other advanced features that are enabled by default.

This warning is emitted when the kernel doesn't support socket-level
LB tracing. That feature is however enabled by default and only kernels
5.7+ support it. That means this warning will be displayed by default to
a lot of users.

This commit reduces the log level to Info to avoid that and to be
consistent with other advanced features that are enabled by default.

Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
@pchaigno pchaigno added release-note/misc This PR makes changes that have no direct user impact. feature/socket-lb Impacts the Socket-LB part of Cilium's kube-proxy replacement. needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Nov 6, 2024
@pchaigno
Copy link
Member Author

pchaigno commented Nov 6, 2024

/test

@pchaigno pchaigno marked this pull request as ready for review November 6, 2024 10:53
@pchaigno pchaigno requested a review from a team as a code owner November 6, 2024 10:53
@pchaigno pchaigno requested review from markpash and borkmann and removed request for markpash November 6, 2024 10:53
@pchaigno pchaigno enabled auto-merge November 6, 2024 11:00
@pchaigno pchaigno added this pull request to the merge queue Nov 7, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 7, 2024
Merged via the queue into cilium:main with commit 25c125b Nov 7, 2024
72 checks passed
@pchaigno pchaigno deleted the socket-lb-tracing-reduce-warning branch November 7, 2024 16:46
@viktor-kurchenko viktor-kurchenko mentioned this pull request Nov 12, 2024
13 tasks
@viktor-kurchenko viktor-kurchenko added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Nov 12, 2024
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. feature/socket-lb Impacts the Socket-LB part of Cilium's kube-proxy replacement. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants