pkg/redirectpolicy: Delete unused variable in getAndUpsertPolicySvcCo… #35794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aditighag I don't have to proper context on this specific bit of code. The unused variable seems to be there since the file was first created. Is this really dead code or is it a bug that we are not doing anything with the configured port names? |
ysksuzuki
reviewed
Nov 7, 2024
There was a problem hiding this comment.
Nice catch. Thanks! Just one nit.
I check the code here and indeed, there's no need to retrieve the port names here. What’s needed here is the ClusterIP of the frontend service and set it to feAddr.AddrCluster and update policyFrontendsByHash and policyConfigs
ysksuzuki
approved these changes
Nov 8, 2024
|
/test |
…nfig In the handler of case svcFrontendNamedPorts, the "ports" is allocated and assigned with values, but never used. Thus, delete the related code. Fixes: e7bb8a7 ("k8s/cilium Event handlers and processing logic for LRPs") Signed-off-by: Zijian Zhang <zijianzhang@bytedance.com>
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the handler of case svcFrontendNamedPorts, the "ports" is allocated and assigned with values, but never used. Thus, delete the related code.
Fixes: e7bb8a7 ("k8s/cilium Event handlers and processing logic for LRPs")