Skip to content

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Nov 5, 2024

Once this PR is merged, a GitHub action will update the labels of these PRs:

 35784

@sayboras sayboras added kind/backports This PR provides functionality previously merged into master. backport/1.15 This PR represents a backport for Cilium 1.15.x of a PR that was merged to main. labels Nov 5, 2024
@sayboras sayboras requested a review from gandro November 5, 2024 23:50
@sayboras
Copy link
Member Author

sayboras commented Nov 6, 2024

/test-backport-1.15

[ upstream commit 0a5054a ]

In some cases, there might be race condition between Instance Manager
(running in operator) and IPAM (running in agent) modules, which could
lead to IP details are not populated properly, and hence cause the below
fatal error. This commit is to make sure that we don't proceed if the
required CIDRs are not populated.

```
time="2024-10-22T22:48:31Z" level=fatal msg="failed to start: daemon creation failed: failed to coalesce CIDRs: invalid CIDR address: " subsys=daemon
```
Suggested-by: Sebastian Wicki <gandro@gmx.net>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/v1.15-backport-2024-11-06-10-48 branch from ec51cc8 to 37ff3d3 Compare November 9, 2024 02:38
@sayboras
Copy link
Member Author

sayboras commented Nov 9, 2024

/test-backport-1.15

@sayboras sayboras marked this pull request as ready for review November 9, 2024 02:38
@sayboras sayboras requested a review from a team as a code owner November 9, 2024 02:38
@sayboras sayboras merged commit d17c1f7 into v1.15 Nov 12, 2024
251 checks passed
@sayboras sayboras deleted the pr/v1.15-backport-2024-11-06-10-48 branch November 12, 2024 04:31
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.15 This PR represents a backport for Cilium 1.15.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants