Skip to content

v1.16 Backports 2024-11-06 #35792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Nov 5, 2024

Once this PR is merged, a GitHub action will update the labels of these PRs:

 35784

@sayboras sayboras added kind/backports This PR provides functionality previously merged into master. backport/1.16 This PR represents a backport for Cilium 1.16.x of a PR that was merged to main. labels Nov 5, 2024
@sayboras sayboras requested a review from gandro November 5, 2024 23:50
@sayboras
Copy link
Member Author

sayboras commented Nov 6, 2024

/test-backport-1.16

@sayboras sayboras added the release-blocker/1.16 This issue will prevent the release of the next version of Cilium. label Nov 6, 2024
[ upstream commit 0a5054a ]

In some cases, there might be race condition between Instance Manager
(running in operator) and IPAM (running in agent) modules, which could
lead to IP details are not populated properly, and hence cause the below
fatal error. This commit is to make sure that we don't proceed if the
required CIDRs are not populated.

```
time="2024-10-22T22:48:31Z" level=fatal msg="failed to start: daemon creation failed: failed to coalesce CIDRs: invalid CIDR address: " subsys=daemon
```
Suggested-by: Sebastian Wicki <gandro@gmx.net>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/v1.16-backport-2024-11-06-10-45 branch from a924289 to cddef12 Compare November 9, 2024 01:58
@sayboras sayboras marked this pull request as ready for review November 9, 2024 01:58
@sayboras sayboras requested a review from a team as a code owner November 9, 2024 01:58
@sayboras
Copy link
Member Author

sayboras commented Nov 9, 2024

/test-backport-1.16

@sayboras sayboras added this pull request to the merge queue Nov 9, 2024
Merged via the queue into v1.16 with commit 4713f27 Nov 9, 2024
279 of 281 checks passed
@sayboras sayboras deleted the pr/v1.16-backport-2024-11-06-10-45 branch November 9, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.16 This PR represents a backport for Cilium 1.16.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. release-blocker/1.16 This issue will prevent the release of the next version of Cilium.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants