Skip to content

[v1.16] envoy: Add configuration for OverloadManager #35787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Nov 5, 2024

@sayboras sayboras requested a review from a team as a code owner November 5, 2024 15:34
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.16 This PR represents a backport for Cilium 1.16.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Nov 5, 2024
@sayboras sayboras changed the title envoy: Add configuration for OverloadManager [v1.16] envoy: Add configuration for OverloadManager Nov 5, 2024
@sayboras
Copy link
Member Author

sayboras commented Nov 5, 2024

/test-backport-1.16

@sayboras sayboras enabled auto-merge November 7, 2024 04:53
This commit is to replace the existing but deprecating runtime key e.g.
global_downstream_max_connections by OverloadManager[^1] as suggested by
the below warning log.

```
level=warning msg="[Usage of the deprecated runtime key overload.global_downstream_max_connections, consider switching to `envoy.resource_monitors.downstream_connections` instead.This runtime key will be removed in future." subsys=envoy-main threadID=246
level=warning msg="[There is no configured limit to the number of allowed active downstream connections. Configure a limit in `envoy.resource_monitors.downstream_connections` resource monitor." subsys=envoy-main threadID=246
```

[^1]: https://www.envoyproxy.io/docs/envoy/latest/configuration/operations/overload_manager/overload_manager#limiting-active-connections

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/envoy-deprecated branch from 5629c7f to 20436d8 Compare November 8, 2024 13:37
@sayboras
Copy link
Member Author

sayboras commented Nov 8, 2024

/test-backport-1.16

@sayboras sayboras added this pull request to the merge queue Nov 9, 2024
Merged via the queue into v1.16 with commit 03f9d5f Nov 9, 2024
278 of 279 checks passed
@sayboras sayboras deleted the pr/tammach/envoy-deprecated branch November 9, 2024 00:39
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.16 This PR represents a backport for Cilium 1.16.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants