k8s: Avoid panic while checking ip mode #35782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
approved these changes
Nov 5, 2024
Good point, unit test is added to cover for this case. |
|
/test |
fc36767 to
16fd428
Compare
|
/test |
1 similar comment
|
/test |
|
tested in my cluster with the image disgest from the PR and confirmed it working |
|
/test |
nathanjsweet
approved these changes
Nov 6, 2024
|
/test |
1 similar comment
|
/test |
|
/test |
|
/test |
Update if condition to avoid panic if ip mode is nil, as OR operator is
having higher precedence than AND operator.
```
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x222dcb0]
goroutine 444 [running]:
github.com/cilium/cilium/pkg/k8s.ParseService(0x400308f0e0, {0x40030a8480, 0x3, 0x4})
/go/src/github.com/cilium/cilium/pkg/k8s/service.go:232 +0x1320
github.com/cilium/cilium/pkg/k8s.(*ServiceCache).UpdateService(0x4001f10c60, 0x400308f0e0, 0x400133f680)
/go/src/github.com/cilium/cilium/pkg/k8s/service_cache.go:337 +0x1e8
github.com/cilium/cilium/pkg/k8s/watchers.(*K8sServiceWatcher).upsertK8sServiceV1(0x40005f9400, 0x400308f0e0, 0x10?)
/go/src/github.com/cilium/cilium/pkg/k8s/watchers/service.go:142 +0x30
github.com/cilium/cilium/pkg/k8s/watchers.(*K8sServiceWatcher).serviceEventLoop(0x40005f9400, 0x400190be38, 0x400133f680)
/go/src/github.com/cilium/cilium/pkg/k8s/watchers/service.go:130 +0x1f4
created by github.com/cilium/cilium/pkg/k8s/watchers.(*K8sServiceWatcher).servicesInit in goroutine 1
/go/src/github.com/cilium/cilium/pkg/k8s/watchers/service.go:101 +0x160
```
Fixes: ab8557c
Signed-off-by: Tam Mach <tam.mach@cilium.io>
16fd428 to
3684b8e
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update if condition to avoid panic if ip mode is nil, as OR operator is having higher precedence than AND operator.
Reported-by: https://github.com/Truongnht
Fixes: ab8557c