Skip to content

Conversation

joamaki
Copy link
Contributor

@joamaki joamaki commented Nov 5, 2024

Once this PR is merged, a GitHub action will update the labels of these PRs:

 32598

[ upstream commit 279a8b7 ]

As per below [^1], the correct parameter is ssh-connect-wait-retries
instead of ssh-startup-wait-retries.

[^1]: https://github.com/cilium/little-vm-helper/blob/3c748d6fc9d6c44a433de85a66f70e8f7043be04/action.yaml#L30

Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
@joamaki joamaki added kind/backports This PR provides functionality previously merged into master. backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. labels Nov 5, 2024
@joamaki joamaki requested a review from sayboras November 5, 2024 12:53
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

@joamaki
Copy link
Contributor Author

joamaki commented Nov 5, 2024

/test-backport-1.14

@joamaki joamaki marked this pull request as ready for review November 5, 2024 14:00
@joamaki joamaki requested a review from a team as a code owner November 5, 2024 14:00
@joamaki joamaki enabled auto-merge (rebase) November 6, 2024 10:55
@joamaki joamaki merged commit 6c5b4ff into v1.14 Nov 6, 2024
237 checks passed
@joamaki joamaki deleted the pr/v1.14-backport-2024-11-05-01-53 branch November 6, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants