Skip to content

cgroup: downgrade the socket LB tracing setup failure log to Info #35775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2024
Merged

cgroup: downgrade the socket LB tracing setup failure log to Info #35775

merged 1 commit into from
Nov 6, 2024

Conversation

ysksuzuki
Copy link
Member

@ysksuzuki ysksuzuki commented Nov 5, 2024 •
edited
Loading

The failure log message doesn't indicate a serious problem and it's not actionable for users. (They can't fix it by adjusting the cilium configuration.) So this commit downgrades it to info.

The socket LB tracing is an optional feature for troubleshooting to see svc->backend translation trace messages.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 5, 2024
@ysksuzuki ysksuzuki force-pushed the downgrade-log-socket-tracing branch from 30e9e39 to 1105e44 Compare November 5, 2024 12:32
@ysksuzuki ysksuzuki added release-note/misc This PR makes changes that have no direct user impact. feature/socket-lb Impacts the Socket-LB part of Cilium's kube-proxy replacement. labels Nov 5, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 5, 2024
@ysksuzuki
Copy link
Member Author

/test

@ysksuzuki ysksuzuki marked this pull request as ready for review November 5, 2024 14:07
@ysksuzuki ysksuzuki requested review from a team as code owners November 5, 2024 14:07
qmonnet
qmonnet approved these changes Nov 6, 2024
View reviewed changes
@ysksuzuki
cgroup: downgrade the socket LB tracing setup failure log to Info
cf90063 
The failure log message doesn't indicate a serious problem, and
it's not actionable for users. (They can't fix it by adjusting
the cilium configuration.) So, this commit downgrades it to info.

The socket LB tracing is an optional feature for troubleshooting to
see svc->backend translation trace messages.

Signed-off-by: Yusuke Suzuki <yusuke.suzuki@isovalent.com>
@ysksuzuki ysksuzuki force-pushed the downgrade-log-socket-tracing branch from 1105e44 to cf90063 Compare November 6, 2024 13:31
@ysksuzuki
Copy link
Member Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 6, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Nov 6, 2024
Merged via the queue into cilium:main with commit 7377d53 Nov 6, 2024
64 checks passed
@julianwiedmann julianwiedmann added affects/v1.15 This issue affects v1.15 branch affects/v1.16 This issue affects v1.16 branch labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkmann borkmann borkmann approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
affects/v1.15 This issue affects v1.15 branch affects/v1.16 This issue affects v1.16 branch feature/socket-lb Impacts the Socket-LB part of Cilium's kube-proxy replacement. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ysksuzuki @borkmann @qmonnet @julianwiedmann