Revert "sysdump: collect Cilium profiling data as first task" #35771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d34a7b3. The reverted commit moved the collection of Cilium profiling data as first task, to prevent it from being impacted by the other sysdump collection tasks. However, the current approach has the unintended consequence of collecting each pprof sequentially, hence taking a significant amount of time, proportional to the number of nodes (approximately one hour with 100 nodes). Let's revert this for now, while figuring out a better approach to achieve the same goal. Reported-by: Marcel Zieba <marcel.zieba@isovalent.com> Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d34a7b3.
The reverted commit moved the collection of Cilium profiling data as first task, to prevent it from being impacted by the other sysdump collection tasks. However, the current approach has the unintended consequence of collecting each pprof sequentially, hence taking a significant amount of time, proportional to the number of nodes (approximately one hour with 100 nodes). Let's revert this for now, while figuring out a better approach to achieve the same goal.
Reported-by: Marcel Zieba marcel.zieba@isovalent.com