Skip to content

[v1.16] Envoy simplify listener setup 1.16 #35764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jrajahalme
Copy link
Member

Once this PR is merged, a GitHub action will update the labels of these PRs:

 35642

[ upstream commit 06ad0eb ]

Listeners are only created when first needed and deleted when not needed
any more. Log these events so that they are visible without debug logs.

Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
[ upstream commit 2b3b761 ]

Rely on xDS cache for listener creation rather than reference
counting. After this the listener reference counting is only used for
deleting the listener when the reference count gets to zero.

Do not ignore xDS messages with invalid nonce, as that could lead to a
stalled stream. Cancel the stream instead so that Envoy would reopen a
new one.

Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jrajahalme jrajahalme added kind/backports This PR provides functionality previously merged into master. backport/1.16 This PR represents a backport for Cilium 1.16.x of a PR that was merged to main. labels Nov 5, 2024
@jrajahalme jrajahalme requested a review from a team as a code owner November 5, 2024 10:04
@jrajahalme
Copy link
Member Author

/test-backport-1.16

@jrajahalme jrajahalme enabled auto-merge November 6, 2024 09:58
@jrajahalme jrajahalme added this pull request to the merge queue Nov 7, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 7, 2024
Merged via the queue into cilium:v1.16 with commit 43ae884 Nov 7, 2024
64 checks passed
@jrajahalme jrajahalme deleted the envoy-simplify-listener-setup-1.16 branch November 7, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.16 This PR represents a backport for Cilium 1.16.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants