option: Reduce log level for WG strict mode + IPv6 #35763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WireGuard strict mode isn't supported with IPv6. At the moment, a warning is emitted if both are enabled at the same time, to warn the user that IPv6 traffic won't be protected. There is however not much the user can do in this case to make the warning go away. Gray also pointed out that users should know that already as they've had to configure encryption.strictMode.cidr with an IPv4 CIDR. It is also documented in the guide. This commit therefore reduces the log to an Info level. Suggested-by: Gray Liang <gray.liang@isovalent.com> Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
81966a0 to
01a8a96
Compare
|
/test |
doniacld
approved these changes
Nov 5, 2024
3u13r
approved these changes
Nov 5, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WireGuard strict mode isn't supported with IPv6. At the moment, a warning is emitted if both are enabled at the same time, to warn the user that IPv6 traffic won't be protected.
There is however not much the user can do in this case to make the warning go away. Gray also pointed out that users should know that already as they've had to configure
encryption.strictMode.cidrwith an IPv4 CIDR. It is also documented in the guide. This commit therefore reduces the log to an Info level.cc @benschlueter @3u13r