Skip to content

helm: New socketLB.tracing flag #35747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2024
Merged

helm: New socketLB.tracing flag #35747

merged 1 commit into from
Nov 5, 2024

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Nov 4, 2024

This helm flag maps to the --trace-sock agent flag.

New Helm flag `socketLB.tracing` to allow disabling socket-level LB tracing.

@pchaigno
helm: New socketLB.tracing flag
a12629a 
This helm flag maps to the --trace-sock agent flag.

Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
@pchaigno pchaigno added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. area/helm Impacts helm charts and user deployment experience feature/socket-lb Impacts the Socket-LB part of Cilium's kube-proxy replacement. labels Nov 4, 2024
@pchaigno
Copy link
Member Author

pchaigno commented Nov 4, 2024

/test

@pchaigno pchaigno added the needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch label Nov 4, 2024
@pchaigno pchaigno marked this pull request as ready for review November 4, 2024 19:59
@pchaigno pchaigno requested review from a team as code owners November 4, 2024 19:59
@pchaigno pchaigno enabled auto-merge November 4, 2024 22:05
@pchaigno pchaigno added this pull request to the merge queue Nov 5, 2024
Merged via the queue into cilium:main with commit 3972783 Nov 5, 2024
74 checks passed
@pchaigno pchaigno deleted the helm-trace-sock branch November 5, 2024 10:08
@joamaki joamaki mentioned this pull request Nov 5, 2024
Merged
23 tasks
@joamaki joamaki added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Nov 5, 2024
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Nov 7, 2024
@cilium-release-bot cilium-release-bot bot mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@nathanjsweet nathanjsweet Awaiting requested review from nathanjsweet nathanjsweet is a code owner automatically assigned from cilium/sig-k8s

Assignees
No one assigned
Labels
area/helm Impacts helm charts and user deployment experience backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. feature/socket-lb Impacts the Socket-LB part of Cilium's kube-proxy replacement. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pchaigno @gandro @joamaki