Skip to content

enabling cli pod-to-pod-with-l7-policy-encryption for v1.15 and v1.16 #35742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2024
Merged

enabling cli pod-to-pod-with-l7-policy-encryption for v1.15 and v1.16 #35742

merged 1 commit into from
Nov 22, 2024

Conversation

smagnani96
Copy link
Contributor

PR to enable the cli pod-to-pod-with-l7-policy-encryption test with IPSec also for v1.15 and v1.16.
Backports of #35173 have beed done in #35586 and #35543 respectively.

Enabling IPSec pod-to-pod-with-l7-policy-encryption connectivity test for v1.15 and v1.16.

@smagnani96 smagnani96 added kind/enhancement This would improve or streamline existing functionality. area/cli Impacts the command line interface of any command in the repository. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. release-note/ci This PR makes changes to the CI. cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Nov 4, 2024
@smagnani96
Copy link
Contributor Author

/test

julianwiedmann
julianwiedmann reviewed Nov 4, 2024
View reviewed changes
@smagnani96
enabling pod-to-pod-with-l7-policy-encryption for v1.15 and v1.16
611ee3c 
This commit enables the `pod-to-pod-with-l7-policy-encryption` cli
connectivity test for v1.15 and v1.16, after the backports of cilium#35173 in:

* v1.15: cilium#35586
* v1.16: cilium#35543

While enabling the test, in this commit we split the version check logic
(that is independent from the IP family used) from the check for running
IPv6+IPsec (that should be prevented due to a current limitation of
having a flaky plain-text packet in the test suite, tracked in cilium#35485).

Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
@smagnani96 smagnani96 force-pushed the pr/ipsec-pod-to-pod-with-l7-policy-v1.15 branch from 70cd08c to 611ee3c Compare November 5, 2024 10:14
@smagnani96
Copy link
Contributor Author

/test

@smagnani96 smagnani96 changed the title enabling cli pod-to-pod-with-l7-policy-encryption from v1.15 enabling cli pod-to-pod-with-l7-policy-encryption for v1.15 and v1.16 Nov 6, 2024
@smagnani96 smagnani96 marked this pull request as ready for review November 6, 2024 11:59
@smagnani96 smagnani96 requested a review from a team as a code owner November 6, 2024 11:59
julianwiedmann
julianwiedmann approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@julianwiedmann julianwiedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! If you want we can wait (a ~week?) with merging until the next patch releases have shipped, so that the version numbers are final? There probably won't be a CLI release before that.

@julianwiedmann julianwiedmann added the feature/ipsec Relates to Cilium's IPsec feature label Nov 8, 2024
@smagnani96 smagnani96 added the dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs label Nov 8, 2024
@smagnani96
Copy link
Contributor Author

lgtm! If you want we can wait (a ~week?) with merging until the next patch releases have shipped, so that the version numbers are final? There probably won't be a CLI release before that.

Yep, let's do this, I just added the label 👍
Will double-check this again next week after the release.

ldelossa
ldelossa approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tklauser
Copy link
Member

lgtm! If you want we can wait (a ~week?) with merging until the next patch releases have shipped, so that the version numbers are final? There probably won't be a CLI release before that.

Yep, let's do this, I just added the label 👍 Will double-check this again next week after the release.

@smagnani96 the Cilium stable releases have happened, so I guess this could be unblocked so it will be part of the upcoming CLI release?

@tklauser tklauser enabled auto-merge November 22, 2024 11:06
@smagnani96 smagnani96 removed the dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs label Nov 22, 2024
@tklauser tklauser added this pull request to the merge queue Nov 22, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 22, 2024
Merged via the queue into cilium:main with commit ca1dec2 Nov 22, 2024
69 checks passed
@github-actions github-actions bot mentioned this pull request Dec 9, 2024
Open
@smagnani96 smagnani96 deleted the pr/ipsec-pod-to-pod-with-l7-policy-v1.15 branch March 18, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldelossa ldelossa ldelossa approved these changes

@julianwiedmann julianwiedmann julianwiedmann approved these changes

Assignees
No one assigned
Labels
area/cli Impacts the command line interface of any command in the repository. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary feature/ipsec Relates to Cilium's IPsec feature kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smagnani96 @tklauser @ldelossa @julianwiedmann