bpf: nat: support additional code points for IPv4 ICMP_DEST_UNREACH #35636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some more code points for ICMP_DEST_UNREACH. For the SNAT / RevSNAT of the inner packet we can re-use the existing ICMP_FRAG_NEEDED code. In particular this enables the EGW to return such ICMP responses back to the client pod. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
4ea0da4 to
aa06712
Compare
|
/test |
4 tasks
jibi
reviewed
Oct 30, 2024
|
(stashed some tests in #35672, but that's not ready for prime-time yet / more effort to backport) |
jibi
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some more code points for ICMP_DEST_UNREACH. For the SNAT / RevSNAT of
the inner packet we can re-use the existing ICMP_FRAG_NEEDED code.
In particular this enables the EGW to return such ICMP responses back
to the client pod.