hubble-relay: Return underlying connection errors when connecting to peer manager #35632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Error for peer manager client When connecting to the hubble peer manager ensure we return the underlying connection error so it's easier to diagnose connection related problems. Currently the only error returned is the context timeout: ``` time="2024-09-18T21:13:13Z" level=warning msg="Failed to create peer client for peers synchronization; will try again after the timeout has expired" error="context deadline exceeded" subsys=hubble-relay target="hubble-peer.kube-system.svc.cluster.local.:443" ``` This will ensure the underlying connection level error is returned when the context is cancelled. In the future we should switch to not using grpc.WithBlock at all which avoids many of these problems, but that requires more testing. In the short-term, lets set these dial options to improve things now, in-case the switch to non-blocking dials is delayed. Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
rolinh
approved these changes
Oct 30, 2024
|
/test |
rolinh
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Sorry, got confused with the ClientConnBuilder for a moment (vs ClientBuilder). So in effect, we've been using these options to connect to Hubble peers for a long time but never did for the connection to the peer manager itself. All good, let's merge this change.
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connecting to the hubble peer manager ensure we return the underlying connection error so it's easier to diagnose connection related problems.
Currently the only error returned is the context timeout:
This will ensure the underlying connection level error is returned when the context is cancelled.
In the future we should switch to not using grpc.WithBlock at all which avoids many of these problems, but that requires more testing. In the short-term, lets set these dial options to improve things now, in-case the switch to non-blocking dials is delayed.
I'm marking for backport to v1.15 and 1.16 because the change is small and will be a huge improvement in errors that users see returned in Hubble Relay logs when they have an issue with Hubble Relay connecting to cilium agent.