Skip to content

docs/xfrm: Fix incorrect statement regarding XFRM IN policies #35626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2024
Merged

docs/xfrm: Fix incorrect statement regarding XFRM IN policies #35626

merged 1 commit into from
Nov 4, 2024

Conversation

pchaigno
Copy link
Member

That previous statement about matching states or sockets was incorrect. The new statement was verified with several tests in our CI.

@pchaigno pchaigno added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. feature/ipsec Relates to Cilium's IPsec feature needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Oct 29, 2024
@pchaigno pchaigno requested a review from ldelossa October 29, 2024 19:57
@pchaigno pchaigno requested review from a team as code owners October 29, 2024 19:57
@jschwinger233 jschwinger233 removed their request for review October 30, 2024 03:29
@jschwinger233
Copy link
Member

LGTM, but Louis knows level use better than me, let him have a say.

ldelossa
ldelossa reviewed Oct 30, 2024
View reviewed changes
ldelossa
ldelossa approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small suggestion around grammar.

learnitall
learnitall approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the delay.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 1, 2024
@jschwinger233 jschwinger233 removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 1, 2024
@pchaigno pchaigno force-pushed the docs-fix-xfrm-guide branch from 7da2af5 to 743e76d Compare November 4, 2024 19:55
@pchaigno @ldelossa
docs/xfrm: Fix incorrect statement regarding XFRM IN policies
34d333c 
That previous statement about matching states or sockets was incorrect.
The new statement was verified with several tests in our CI.

Co-authored-by: Louis DeLosSantos <louis.delos@isovalent.com>
Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
@pchaigno pchaigno force-pushed the docs-fix-xfrm-guide branch from 743e76d to 34d333c Compare November 4, 2024 19:57
@pchaigno pchaigno enabled auto-merge November 4, 2024 19:58
@pchaigno pchaigno added this pull request to the merge queue Nov 4, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 4, 2024
Merged via the queue into cilium:main with commit 07fd8d5 Nov 4, 2024
59 checks passed
@pchaigno pchaigno deleted the docs-fix-xfrm-guide branch November 4, 2024 20:21
@joamaki joamaki mentioned this pull request Nov 5, 2024
Merged
23 tasks
@joamaki joamaki added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Nov 5, 2024
@github-actions github-actions bot removed the backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. label Nov 7, 2024
@github-actions github-actions bot added the backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. label Nov 7, 2024
@cilium-release-bot cilium-release-bot bot mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldelossa ldelossa ldelossa approved these changes

@jschwinger233 jschwinger233 jschwinger233 approved these changes

+1 more reviewer

@learnitall learnitall learnitall approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. feature/ipsec Relates to Cilium's IPsec feature ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pchaigno @jschwinger233 @ldelossa @learnitall @joamaki