l7lb: fix registration of flag loadbalancer-l7 #35623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the flag `loadbalancer-l7` isn't properly registered. Even though it's working fine when reading the config property from the Cilium Configmap, it's not working when trying to use the flag as Go flag. ``` 2024-10-29T16:24:26Z debug layer=debugger Adding target 23 "/usr/bin/cilium-operator-generic-bin --config-dir=/tmp/cilium/config-map --debug=true --loadbalancer-l7=envoy" Error: unknown flag: --loadbalancer-l7 ``` Therefore, this commit is moving the config property into the respective Hive Cell where it gets properly registered. Reported-by: André Martins <andre@cilium.io> Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
|
/test |
pippolo84
approved these changes
Oct 29, 2024
aanm
approved these changes
Oct 29, 2024
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the flag
loadbalancer-l7isn't properly registered.Even though it's working fine when reading the config property from the Cilium Configmap, it's not working when trying to use the flag as Go flag.
Therefore, this commit is moving the config property into the respective Hive Cell where it gets properly registered.
Reported-by: André Martins andre@cilium.io
Note: The initial PR that moved this logic and flags into a Hive Cell probably skipped moving the config flag
loadbalancer-l7as there might be multiple cells that implement L7 loadbalancing functionality in the future. While this might be true, IMO it's ok to move if for the time being and deal with this later.