bgpv2,doc: Update troubleshooting doc with CiliumBGPClusterConfig status conditions #35601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
985f07d to
e283fa1
Compare
rastislavs
reviewed
Oct 29, 2024
Documentation/network/bgp-control-plane/bgp-control-plane-troubleshooting.rst
Outdated
Show resolved
Hide resolved
qmonnet
approved these changes
Oct 29, 2024
The current owner reference check checks the owner just by the name. This may matches to the owner of different kind of resource with the same name. Practically, it shouldn't happen, but for the sake of correctness, fix it. Also, unexport the IsOwner function since it is only used within the package. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
Introduce a new status condition ConflictingClusterConfig to the CiliumBGPClusterConfig which indicates that the ClusterConfig is selecting the node that is already selected by other ClusterConfig. We reused an existing conflict detection mechanism in the Cilium Operator which checks the existing NodeConfig's owner reference when it tries to create the new NodeConfig. If there's another ClusterConfig owning the same node, it is observed as a conflict. Because of this detection mechanism, the condition in the single ClusterConfig doesn't have the global view of the conflict relationship. To get the complete view, users need to gather the observed conflicts from multiple ClusterConfigs. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
e54900f to
c08cecf
Compare
tommyp1ckles
approved these changes
Oct 30, 2024
Now Cilium reports nodeSelector conflict of the CiliumBGPClusterConfig with status condition instead of log. Update the corresponding troubleshooting document. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
Add another troubleshooting entry for misconfigured nodeSelector. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
Add another troubleshooting doc entry for misconfigured peerConfigRef. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
e283fa1 to
03b2c1e
Compare
|
/test |
rastislavs
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced a few status conditions in the
CiliumBGPClusterConfigfor error reporting (#35517, #35527, #35593). Update the troubleshooting guide to leverage them.