bugtool: deprecate flag k8s-mode
#35689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf4f75c to
791aa47
Compare
|
/test |
tklauser
reviewed
Nov 1, 2024
michi-covalent
approved these changes
Nov 1, 2024
derailed
approved these changes
Nov 1, 2024
Historically, the bugtool has support for fetching system information from a Cilium Agent via Kubernetes API. In these cases, the bugtool is running outside of the agent and the flag `k8s-mode=true` is set. Nowadays, Cilium CLI (e.g. `cilium sysdump`) is used to gather information from Cilium running in a K8s cluster. In this case, the bugtool is always running within the agent. Therefore, this commit deprecates the flag `k8s-mode` (and it's related flags `cilium-agent-container-name`, `k8s-namespace` & `k8s-label`). It will be completely removed with Cilium 1.18. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
791aa47 to
638d812
Compare
|
/test |
joestringer
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, the bugtool has support for fetching system information from a Cilium Agent via Kubernetes API. In these cases, the bugtool is running outside of the agent and the flag
k8s-mode=trueis set.Nowadays, Cilium CLI (e.g.
cilium sysdump) is used to gather information from Cilium running in a K8s cluster. In this case, the bugtool is always running within the agent.Therefore, this commit deprecates the flag
k8s-mode(and it's related flagscilium-agent-container-name,k8s-namespace&k8s-label). It will be completely removed with Cilium 1.18.