workflows/ingress: Run basic checks #35683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
489c1b8 to
b581aac
Compare
brlbil
requested changes
Nov 4, 2024
There was a problem hiding this comment.
We should also add Upload Junits step after Upload artifacts
- name: Upload JUnits [junit]
if: ${{ always() }}
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
with:
name: cilium-junits-${{ matrix.name }}
path: cilium-junits/*.xml
and merge-upload job after ingress-conformance-test job
merge-upload job can be same from other workflows
b581aac to
9d95c60
Compare
|
@brlbil Thanks for the review! Seeing this I'm wondering if the JUnit stuff is even needed here, considering we're only going to run 2-3 tests tops (and only one currently). What do we gain from reporting those results via JUnit? |
|
@pchaigno Junits are used in reporting tools to list which tests failed with workflow etc... But if you think it is not necessary then by all means remove the |
9d95c60 to
76379d7
Compare
This workflow doesn't run the CLI connectivity tests, so it's missing some basic checks such as unexpected packet drops. This commit adds it. The check-log-errors test should also be enabled, but it is currently failing because there are errors in logs whenever enabling Ingress. It can be added once those errors are fixed. Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
76379d7 to
6a042e5
Compare
|
@brlbil We discussed it with Tam and the JUnit stuff probably isn't needed here for the time being (probably to be reconsidered if more connectivity tests are covered.) |
|
/test |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workflow doesn't run the CLI connectivity tests, so it's missing some basic checks such as unexpected packet drops. This commit adds it.
The check-log-errors test should also be enabled, but it is currently failing because there are errors in logs whenever enabling Ingress. It can be added once those errors are fixed.