-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Additionally test KVStore mode in E2E/IPSec workflows #35679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/ci-e2e-upgrade |
e13bd48
to
81a2cba
Compare
/ci-e2e-upgrade |
/ci-ipsec-e2e |
/ci-ipsec-upgrade |
81a2cba
to
a0ba83e
Compare
/ci-ipsec-e2e |
/ci-ipsec-upgrade |
a0ba83e
to
a825907
Compare
/ci-ipsec-e2e |
/ci-ipsec-upgrade |
/ci-e2e-upgrade |
Starting to open for review to gather feedback. The first commit is from #35646 which shall be merged first (hence I marked this one as blocked). |
a825907
to
c1880f5
Compare
Rebased onto main to drop the commit from #35646. |
ldelossa
approved these changes
Nov 11, 2024
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/CI
Continuous Integration testing issue or flake
area/kvstore
Impacts the KVStore package interactions.
backport/author
The backport will be carried out by the author of the PR.
backport-done/1.14
The backport for Cilium 1.14.x for this PR is done.
backport-done/1.15
The backport for Cilium 1.15.x for this PR is done.
backport-done/1.16
The backport for Cilium 1.16.x for this PR is done.
feature/ipsec
Relates to Cilium's IPsec feature
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/ci
This PR makes changes to the CI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify a few matrix entries of the Cilium E2E Upgrade and IPSec workflows to configure Cilium in kvstore mode, to cover this functionality here as well in addition to the clustermesh workflows. In detail, the etcd instance is executed as a pod running in host network, which is setup via the
kind-kvstore-start
makefile target. The matrix entries are selected trying to cover the most common combinations, that is native-routing/tunneling, KPR off/on and wireguard off/on, and avoiding incompatible options (mainly Egress Gateway and Mutual Authentication).