Skip to content

Additionally test KVStore mode in E2E/IPSec workflows #35679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Oct 31, 2024

Modify a few matrix entries of the Cilium E2E Upgrade and IPSec workflows to configure Cilium in kvstore mode, to cover this functionality here as well in addition to the clustermesh workflows. In detail, the etcd instance is executed as a pod running in host network, which is setup via the kind-kvstore-start makefile target. The matrix entries are selected trying to cover the most common combinations, that is native-routing/tunneling, KPR off/on and wireguard off/on, and avoiding incompatible options (mainly Egress Gateway and Mutual Authentication).

@giorio94 giorio94 added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. area/kvstore Impacts the KVStore package interactions. needs-backport/1.15 needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Oct 31, 2024
@giorio94
Copy link
Member Author

/ci-e2e-upgrade

@giorio94 giorio94 changed the title Additionally test KVStore mode in Cilium E2E Upgrade workflow Additionally test KVStore mode in E2E/IPSec workflows Oct 31, 2024
@giorio94 giorio94 force-pushed the pr/giorio94/main/gha-e2e-kvstore branch from e13bd48 to 81a2cba Compare October 31, 2024 15:30
@giorio94
Copy link
Member Author

/ci-e2e-upgrade

@giorio94
Copy link
Member Author

/ci-ipsec-e2e

@giorio94
Copy link
Member Author

/ci-ipsec-upgrade

@giorio94 giorio94 force-pushed the pr/giorio94/main/gha-e2e-kvstore branch from 81a2cba to a0ba83e Compare October 31, 2024 17:21
@giorio94
Copy link
Member Author

/ci-ipsec-e2e

@giorio94
Copy link
Member Author

/ci-ipsec-upgrade

@giorio94 giorio94 force-pushed the pr/giorio94/main/gha-e2e-kvstore branch from a0ba83e to a825907 Compare October 31, 2024 17:54
@giorio94
Copy link
Member Author

/ci-ipsec-e2e

@giorio94
Copy link
Member Author

giorio94 commented Nov 4, 2024

/ci-ipsec-upgrade

@giorio94
Copy link
Member Author

giorio94 commented Nov 4, 2024

/ci-e2e-upgrade

@giorio94 giorio94 added the dont-merge/blocked Another PR must be merged before this one. label Nov 4, 2024
@giorio94
Copy link
Member Author

giorio94 commented Nov 4, 2024

Starting to open for review to gather feedback. The first commit is from #35646 which shall be merged first (hence I marked this one as blocked).

@giorio94 giorio94 marked this pull request as ready for review November 4, 2024 09:44
@giorio94 giorio94 requested review from a team as code owners November 4, 2024 09:44
@giorio94 giorio94 force-pushed the pr/giorio94/main/gha-e2e-kvstore branch from a825907 to c1880f5 Compare November 5, 2024 14:18
@giorio94
Copy link
Member Author

giorio94 commented Nov 5, 2024

Rebased onto main to drop the commit from #35646.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 11, 2024
@pchaigno pchaigno added this pull request to the merge queue Nov 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 11, 2024
@pchaigno pchaigno added this pull request to the merge queue Nov 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 12, 2024
@sayboras sayboras added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit 2056fa9 Nov 12, 2024
269 checks passed
@sayboras sayboras deleted the pr/giorio94/main/gha-e2e-kvstore branch November 12, 2024 08:39
@giorio94 giorio94 mentioned this pull request Nov 12, 2024
2 tasks
@giorio94 giorio94 added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Nov 12, 2024
@giorio94 giorio94 mentioned this pull request Nov 12, 2024
2 tasks
@giorio94 giorio94 added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. needs-backport/1.14 and removed needs-backport/1.15 labels Nov 12, 2024
@giorio94 giorio94 mentioned this pull request Nov 12, 2024
3 tasks
@giorio94 giorio94 added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 labels Nov 12, 2024
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Nov 12, 2024
@jschwinger233 jschwinger233 added the feature/ipsec Relates to Cilium's IPsec feature label Nov 13, 2024
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/kvstore Impacts the KVStore package interactions. backport/author The backport will be carried out by the author of the PR. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. feature/ipsec Relates to Cilium's IPsec feature ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants