renovate: fix API files generation using renovate #35676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to use renovate to generate the API files, every time protobuf is updated for example, as renovate GitHub action didn't have Golang installed, the generation of files simply fail. Thus we will pass GO as the golang version available on the cilium builder image. Fixes: c6fb9e4 ("Makefile: generate API with protocolbuffers/protobuf update") Signed-off-by: André Martins <andre@cilium.io>
|
/test |
joestringer
approved these changes
Oct 31, 2024
@joestringer It failed here |
brlbil
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to use renovate to generate the API files, every time protobuf is updated for example, as renovate GitHub action didn't have Golang installed, the generation of files simply fail. Thus we will pass GO as the golang version available on the cilium builder image.
Fixes: c6fb9e4 ("Makefile: generate API with protocolbuffers/protobuf update")