Skip to content

cilium-cli: Skip nil details for Service error in check-log-errors #35671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

rastislavs
Copy link
Contributor

Skip the known retrieved nil details for Service error until #35595 is resolved.

Skip the known `retrieved nil details for Service` error
until cilium#35595 is resolved.

Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
@rastislavs rastislavs added area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact. cilium-cli This PR contains changes related with cilium-cli labels Oct 31, 2024
@github-actions github-actions bot added the cilium-cli-exclusive This PR only impacts cilium-cli binary label Oct 31, 2024
@rastislavs
Copy link
Contributor Author

/test

@tommyp1ckles tommyp1ckles added this pull request to the merge queue Nov 7, 2024
Merged via the queue into cilium:main with commit bce68e1 Nov 7, 2024
73 checks passed
@tommyp1ckles
Copy link
Contributor

tommyp1ckles commented Nov 7, 2024

@rastislavs Going to create a new CLI release with this here

Edit: I've been informed we no longer should need a release for this (on main). Will keep an eye on CI to see if this unblocks CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants