Skip to content

cilium-cli:fix --repository flag precedence with cached Helm charts #35670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2024
Merged

cilium-cli:fix --repository flag precedence with cached Helm charts #35670

merged 1 commit into from
Nov 5, 2024

Conversation

renyunkang
Copy link
Contributor

Improves version identification by hashing the repository using SHA256. The first four characters of the hash are appended to filenames as a suffix, providing a unique identifier for each repository version.

Fixes: #35629

Fix: cilium-cli install --repository flag respects repository even with cached versions.

@renyunkang
cilium-cli:fix --repository flag precedence with cached Helm charts
d19f320 
Signed-off-by: renyunkang <rykren1998@gmail.com>
@renyunkang renyunkang requested a review from a team as a code owner October 31, 2024 07:45
@renyunkang renyunkang requested a review from derailed October 31, 2024 07:45
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 31, 2024
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary kind/community-contribution This was a contribution made by a community member. labels Oct 31, 2024
@joestringer joestringer added release-note/bug This PR fixes an issue in a previous release of Cilium. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Oct 31, 2024
@chaunceyjiang
Copy link
Member

/test

@aanm aanm requested review from tklauser and removed request for derailed November 4, 2024 10:37
@aanm aanm enabled auto-merge November 4, 2024 10:37
tklauser
tklauser approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @renyunkang!

@aanm aanm added this pull request to the merge queue Nov 5, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 5, 2024
Merged via the queue into cilium:main with commit 0caa482 Nov 5, 2024
71 checks passed
@github-actions github-actions bot mentioned this pull request Dec 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

Assignees
No one assigned
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cilium-cli: install --repository flag doesn't take effect when there is a cached version
5 participants
@renyunkang @chaunceyjiang @tklauser @joestringer @aanm