Skip to content

cilium: fix integer overflow in netkit probe on 32bit platform #35659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2024
Merged

cilium: fix integer overflow in netkit probe on 32bit platform #35659

merged 1 commit into from
Oct 31, 2024

Conversation

devodev
Copy link
Contributor

@devodev devodev commented Oct 30, 2024 •
edited
Loading

Fix the following error when compiling binaries on linux/386:

Error: ../pkg/datapath/linux/probes/probes.go:498:19: constant 4294967295 overflows int

Related to: #35551
For some reason, the Hubble-cli compile test did not fail in the linked PR, but it did in mine after a rebase here: https://github.com/cilium/cilium/actions/runs/11596542377/job/32288046467?pr=35483

cc @borkmann for validation

Repro when compiling hubble-cli:

$ cd hubble
$ env GOARCH=386 GOOS=linux make
GOOS=linux GOARCH=386 CGO_ENABLED=0 go build  -mod=vendor -ldflags ' -X "github.com/cilium/cilium/pkg/version.ciliumVersion=1.17.0-dev 24a858c572 2024-10-21T19:16:19-04:00" -s -w -X "github.com/cilium/cilium/pkg/envoy.requiredEnvoyVersionSHA=0fdfdb63f28d1701595e9374931c4c570a7f8771" ' -tags=osusergo   -ldflags "-w -s -X 'github.com/cilium/cilium/hubble/pkg.GitBranch=pr/devodev/hubble-auto-port-forward-native' -X 'github.com/cilium/cilium/hubble/pkg.GitHash=24a858c572' -X 'github.com/cilium/cilium/hubble/pkg.Version=1.17.0-dev'" -o ./hubble .
# github.com/cilium/cilium/pkg/datapath/linux/probes
../pkg/datapath/linux/probes/probes.go:498:19: constant 4294967295 overflows int

make: *** [hubble] Error 1

@devodev
cilium: fix integer overflow in netkit probe on 32bit platform
a430be7 
Fix the following error when compiling binaries on linux/386:
Error: ../pkg/datapath/linux/probes/probes.go:498:19: constant 4294967295 overflows int

Signed-off-by: Alexandre Barone <abalexandrebarone@gmail.com>
@devodev devodev requested a review from a team as a code owner October 30, 2024 18:33
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 30, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Oct 30, 2024
@devodev devodev mentioned this pull request Oct 30, 2024
Merged
borkmann
borkmann approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@borkmann borkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@borkmann
Copy link
Member

/test

@borkmann borkmann requested a review from rgo3 October 30, 2024 19:27
michi-covalent
michi-covalent approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

regardin hubble-cli, we stopped releasing 32-bit binaries at some point https://github.com/cilium/hubble/releases so we probably don't need to build them anymore in the CI 🔧

@michi-covalent michi-covalent added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Oct 30, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 30, 2024
@michi-covalent
Copy link
Contributor

/test

@michi-covalent michi-covalent mentioned this pull request Oct 30, 2024
Closed
@michi-covalent michi-covalent added this pull request to the merge queue Oct 31, 2024
Merged via the queue into cilium:main with commit a802f91 Oct 31, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkmann borkmann borkmann approved these changes

@rgo3 rgo3 rgo3 approved these changes

@michi-covalent michi-covalent michi-covalent approved these changes

@dylandreimerink dylandreimerink Awaiting requested review from dylandreimerink dylandreimerink is a code owner automatically assigned from cilium/loader

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devodev @borkmann @michi-covalent @rgo3