Skip to content

Conversation

YutaroHayakawa
Copy link
Member

Introduce a new MissingAuthSecret condition which indicates that the referenced spec.authSecretRef is missing. To achieve that, we introduce a new reconciler logic to the operator which watches the changes to the PeerConfig and Secret and update the condition. Corresponding clusterroole is also added.

bgpv2: Introduce MissingAuthSecret condition to PeerConfig

Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 30, 2024
@YutaroHayakawa YutaroHayakawa added the release-note/misc This PR makes changes that have no direct user impact. label Oct 30, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 30, 2024
@YutaroHayakawa YutaroHayakawa marked this pull request as ready for review October 30, 2024 14:13
@YutaroHayakawa YutaroHayakawa requested review from a team as code owners October 30, 2024 14:13
@YutaroHayakawa
Copy link
Member Author

/test

Introduce a new MissingAuthSecret condition which indicates that the
referenced spec.authSecretRef is missing. To achieve that, we introduce
a new reconciler logic to the operator which watches the changes to the
PeerConfig and Secret and update the condition. Corresponding
clusterroole is also added.

Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
@YutaroHayakawa YutaroHayakawa force-pushed the bgpv2-peer-config-status-condition branch from 55afdda to 3264f21 Compare October 31, 2024 02:20
@YutaroHayakawa
Copy link
Member Author

/test

Copy link
Contributor

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@YutaroHayakawa
Copy link
Member Author

Conformance Ginkgo: Artifact creation failed with timeout. Maybe GH issue?

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 31, 2024
@tklauser tklauser added this pull request to the merge queue Oct 31, 2024
Merged via the queue into cilium:main with commit b0a5c49 Oct 31, 2024
64 checks passed
@YutaroHayakawa YutaroHayakawa added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. and removed release-note/misc This PR makes changes that have no direct user impact. labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants