Skip to content

Fix missing edsClusterConfig in CiliumClusterwideEnvoyConfig for envoy-circuit-breaker.yaml example #35647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2024
Merged

Fix missing edsClusterConfig in CiliumClusterwideEnvoyConfig for envoy-circuit-breaker.yaml example #35647

merged 1 commit into from
Nov 6, 2024

Conversation

kachi-bits
Copy link
Contributor

@kachi-bits kachi-bits commented Oct 30, 2024 •
edited
Loading

Description

This PR addresses an issue in the examples/kubernetes/servicemesh/envoy/envoy-circuit-breaker.yaml example, where the CiliumClusterwideEnvoyConfig in the cluster section is missing the edsClusterConfig field. Without this configuration, Envoy is unable to discover endpoints dynamically, leading to 503 errors due to the lack of upstreams.

Changes

  • Added the missing edsClusterConfig field to CiliumClusterwideEnvoyConfig in the cluster section.

Testing

  1. Deployed the modified envoy-circuit-breaker.yaml in a Kubernetes cluster.
  2. Verified that Envoy correctly connects to upstreams without 503 errors.

Impact

This fix ensures that the envoy-circuit-breaker.yaml example works as expected, enabling proper endpoint discovery and upstream connectivity.

@kachi-bits
Update envoy-circuit-breaker.yaml
df6624c 
Signed-off-by: kachi-bits <76791974+kachi-bits@users.noreply.github.com>
@kachi-bits kachi-bits requested a review from a team as a code owner October 30, 2024 10:41
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 30, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Oct 30, 2024
@kachi-bits kachi-bits changed the title Update envoy-circuit-breaker.yaml Fix missing edsClusterConfig in CiliumClusterwideEnvoyConfig for envoy-circuit-breaker.yaml example Oct 30, 2024
@nathanjsweet nathanjsweet added release-note/bug This PR fixes an issue in a previous release of Cilium. release-note/misc This PR makes changes that have no direct user impact. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. release-note/bug This PR fixes an issue in a previous release of Cilium. labels Oct 30, 2024
@nathanjsweet
Copy link
Member

/test

@aanm aanm requested review from youngnick and removed request for jrajahalme November 4, 2024 10:36
@aanm aanm enabled auto-merge November 6, 2024 16:42
@aanm aanm added this pull request to the merge queue Nov 6, 2024
Merged via the queue into cilium:main with commit 1f5c8dd Nov 6, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@nathanjsweet nathanjsweet Awaiting requested review from nathanjsweet nathanjsweet is a code owner automatically assigned from cilium/sig-k8s

@youngnick youngnick Awaiting requested review from youngnick

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kachi-bits @nathanjsweet @aanm