Skip to content

makefile: add target to install Cilium in kvstore mode #35646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2024
Merged

makefile: add target to install Cilium in kvstore mode #35646

merged 1 commit into from
Nov 5, 2024

Conversation

giorio94
Copy link
Member

Simplify locally testing Cilium configured in kvstore mode via the introduction of a dedicated kind-kvstore-install-cilium target, which takes care of setting up an etcd pod running in host network (pinned to a control plane node) and configuring Cilium to target it.

The creation and deletion of the etcd pod is delegated to the dedicated kind-kvstore-start and kind-kvstore-stop commands.

@giorio94
makefile: add target to install Cilium in kvstore mode
065298d 
Simplify locally testing Cilium configured in kvstore mode via the
introduction of a dedicated `kind-kvstore-install-cilium` target,
which takes care of setting up an etcd pod running in host network
(pinned to a control plane node) and configuring Cilium to target it.

The creation and deletion of the etcd pod is delegated to the dedicated
`kind-kvstore-start` and `kind-kvstore-stop` commands.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 added release-note/misc This PR makes changes that have no direct user impact. area/kvstore Impacts the KVStore package interactions. sig/community Impacts contribution workflow, guidelines, and tools. needs-backport/1.15 needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Oct 30, 2024
@giorio94 giorio94 requested a review from a team as a code owner October 30, 2024 10:32
@giorio94 giorio94 requested a review from borkmann October 30, 2024 10:32
@giorio94 giorio94 mentioned this pull request Oct 31, 2024
Merged
@giorio94
Copy link
Member Author

/test

@giorio94
Copy link
Member Author

giorio94 commented Nov 4, 2024

@borkmann Gentle ping 🙏

sayboras
sayboras approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Morale support ✔️

@tklauser tklauser added this pull request to the merge queue Nov 5, 2024
Merged via the queue into cilium:main with commit 03bde2b Nov 5, 2024
70 checks passed
@giorio94 giorio94 added the backport/author The backport will be carried out by the author of the PR. label Nov 11, 2024
@giorio94 giorio94 mentioned this pull request Nov 12, 2024
Merged
2 tasks
@giorio94 giorio94 added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Nov 12, 2024
@giorio94 giorio94 mentioned this pull request Nov 12, 2024
Merged
2 tasks
@giorio94 giorio94 added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. needs-backport/1.14 and removed needs-backport/1.15 labels Nov 12, 2024
@giorio94 giorio94 mentioned this pull request Nov 12, 2024
Merged
3 tasks
@giorio94 giorio94 added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 labels Nov 12, 2024
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Nov 12, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Nov 12, 2024
This was referenced Nov 13, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@sayboras sayboras sayboras approved these changes

@borkmann borkmann Awaiting requested review from borkmann borkmann is a code owner automatically assigned from cilium/build

Assignees
No one assigned
Labels
area/kvstore Impacts the KVStore package interactions. backport/author The backport will be carried out by the author of the PR. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact. sig/community Impacts contribution workflow, guidelines, and tools.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giorio94 @tklauser @sayboras