Envoy simplify listener setup #35642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
squeed
reviewed
Oct 30, 2024
mhofstetter
approved these changes
Oct 30, 2024
Listeners are only created when first needed and deleted when not needed any more. Log these events so that they are visible without debug logs. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
Rely on xDS cache for listener creation rather than reference counting. After this the listener reference counting is only used for deleting the listener when the reference count gets to zero. Do not ignore xDS messages with invalid nonce, as that could lead to a stalled stream. Cancel the stream instead so that Envoy would reopen a new one. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
77d8fbf to
a019e33
Compare
|
/test |
1 task
1 task
1 task
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rely on xDS cache for listener creation rather than reference counting. After this the listener reference counting is only used for deleting the listener when the reference count gets to zero.
Do not ignore xDS messages with invalid nonce, as that could lead to a stalled stream. Cancel the stream instead so that Envoy would reopen a new one.
Listeners are only created when first needed and deleted when not needed any more. Log these events so that they are visible without debug logs.