Skip to content

docs: Add documentation for Gateway API Addresses Support #35536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2024
Merged

docs: Add documentation for Gateway API Addresses Support #35536

merged 1 commit into from
Nov 15, 2024

Conversation

chaunceyjiang
Copy link
Member

@chaunceyjiang chaunceyjiang commented Oct 25, 2024 •
edited
Loading

Part of #33042

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 25, 2024
@chaunceyjiang chaunceyjiang force-pushed the docs_gatewayapi branch 3 times, most recently from 2aa6a5c to 4da0caa Compare October 25, 2024 09:11
@sayboras sayboras added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Oct 25, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Oct 25, 2024
@chaunceyjiang chaunceyjiang marked this pull request as ready for review October 25, 2024 09:32
@chaunceyjiang chaunceyjiang requested review from a team as code owners October 25, 2024 09:32
@chaunceyjiang chaunceyjiang requested review from youngnick and a user October 25, 2024 09:32
@chaunceyjiang
Copy link
Member Author

/cc @sayboras PTAL.

ghost
ghost reviewed Oct 25, 2024
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good overall, I left a question about a note I didn't understand.

@chaunceyjiang chaunceyjiang requested a review from a user October 30, 2024 14:18
youngnick
youngnick reviewed Nov 4, 2024
View reviewed changes
ghost
ghost reviewed Nov 11, 2024
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After Nick's comments are addressed looks good. @chaunceyjiang Can you address these comments?

@chaunceyjiang
Copy link
Member Author

@lambdanis PTAL.

@chaunceyjiang
docs: Add documentation for Gateway API Addresses Support
d5a663e 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang
Copy link
Member Author

/test

ghost
ghost approved these changes Nov 14, 2024
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chaunceyjiang

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 14, 2024
@aanm aanm added this pull request to the merge queue Nov 15, 2024
Merged via the queue into cilium:main with commit 6621ac5 Nov 15, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngnick youngnick youngnick left review comments

+1 more reviewer
Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chaunceyjiang @youngnick @aanm @sayboras