Skip to content

dbg: increase limit when safely reading envoy metrics via cilium-dbg #35528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2024
Merged

dbg: increase limit when safely reading envoy metrics via cilium-dbg #35528

merged 1 commit into from
Oct 29, 2024

Conversation

mhofstetter
Copy link
Member

Currently, fetching the Envoy metrics via cilium-dbg envoy admin metrics can end up easily with the following exception.

/home/cilium# cilium-dbg envoy admin metrics
Error: cannot get metrics: failed to read "stats/prometheus" response: read limit reached

The reason is the current limit of 1MB when reading the response body with safeio.ReadAllLimit.

Therefore, this commit is increasing the limit to 100MB.

@mhofstetter mhofstetter added kind/enhancement This would improve or streamline existing functionality. area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. area/cli Impacts the command line interface of any command in the repository. release-note/misc This PR makes changes that have no direct user impact. labels Oct 24, 2024
@mhofstetter
Copy link
Member Author

/test

@mhofstetter mhofstetter requested a review from asauber October 24, 2024 15:54
@mhofstetter mhofstetter marked this pull request as ready for review October 24, 2024 15:55
@mhofstetter mhofstetter requested a review from a team as a code owner October 24, 2024 15:55
sayboras
sayboras approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, I thought 1mb payload was enough 😱

@sayboras sayboras enabled auto-merge October 24, 2024 23:25
@mhofstetter
dbg: increase limit when safely reading envoy metrics via cilium-dbg
927d918 
Currently, fetching the Envoy metrics via `cilium-dbg envoy admin metrics`
can end up easily with the following exception.

```
/home/cilium# cilium-dbg envoy admin metrics
Error: cannot get metrics: failed to read "stats/prometheus" response: read limit reached
```

The reason is the current limit of 1MB when reading the response body
with `safeio.ReadAllLimit`.

Therefore, this commit is increasing the limit to `100MB`.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/dbg-envoy-safe-readlimit branch from c488dc9 to 927d918 Compare October 28, 2024 16:33
@mhofstetter
Copy link
Member Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 29, 2024
@sayboras sayboras added this pull request to the merge queue Oct 29, 2024
Merged via the queue into cilium:main with commit 8afaf2b Oct 29, 2024
64 checks passed
@mhofstetter mhofstetter deleted the pr/mhofstetter/dbg-envoy-safe-readlimit branch October 29, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asauber asauber asauber approved these changes

@sayboras sayboras sayboras approved these changes

Assignees
No one assigned
Labels
area/cli Impacts the command line interface of any command in the repository. area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhofstetter @asauber @sayboras