CI: Add channel arguments to GKE related workflows #35522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
143ee3d to
781b6b3
Compare
|
/ci-external-workloads {"runAllVersion":"yes"} |
781b6b3 to
8117068
Compare
|
/ci-external-workloads {"runAllVersion":"yes"} |
|
/ci-external-workloads runAllVersions |
|
/ci-external-workloads |
8117068 to
bdeaefb
Compare
|
/ci-external-workloads channel=stable |
bdeaefb to
668f5bd
Compare
|
/ci-gke channel=stable |
00f1a46 to
59c7b0d
Compare
|
/ci-external-workloads channel=stable |
59c7b0d to
557880a
Compare
|
/ci-gke channel=stable |
|
/ci-external-workloads versions=all |
This commit adds Ariane extra-args to run all GKE versions with the argument versions=all. Normally, these run only on scheduled workflow runs. Also, this commit adds an argument for the GKE channel, if channel=<name> versions given it is filtered for that channel, and channel=none disables filtering. If no argument is given the default channel REGULAR is used. Signed-off-by: Birol Bilgin <birol@cilium.io>
557880a to
1ad192b
Compare
|
/test |
giorio94
reviewed
Oct 25, 2024
|
/ci-gke versions=all channel=stable |
giorio94
approved these changes
Oct 25, 2024
nebril
approved these changes
Oct 28, 2024
aanm
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Ariane extra-args to run all GKE versions with the argument versions=all.
Normally, these run only on scheduled workflow runs.
Also, this PR adds an argument for the GKE channel, if channel= versions given it
is filtered for that channel, and channel=none disables filtering. If no argument is given the default channel REGULAR is used.
The purpose of adding versions=all is to make it easy to test the running of all versions,
and the purpose of adding channel= is that scheduled tests fail without filtering versions with stable channels, especially during version updates on GKE. But at the same time, we want to keep the ability to run tests without channel filtering too.
Runs with arguments:
versions=all https://github.com/cilium/cilium/actions/runs/11515943731
channel=stable https://github.com/cilium/cilium/actions/runs/11515905320