envoy: avoid syncing empty Envoy secret #35521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the Envoy SecretSync on the Cilium Agent (sending K8s secrets from the K8s Secret namespace via xDS to Envoy) sends an "empty" Envoy secret resource if it's not possible to map the K8s secret into a corresponding Envoy secret type. To avoid confusion, this refactoring doesn't sync K8s secrets that can't be mapped to a corresponding Envoy secret type. Suggested-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com> Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
fbcb603 to
4cdadd1
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Envoy SecretSync on the Cilium Agent (sending K8s secrets from the K8s Secret namespace via xDS to Envoy) sends an "empty" Envoy secret resource if it's not possible to map the K8s secret into a corresponding Envoy secret type.
To avoid confusion, this refactoring doesn't sync K8s secrets that can't be mapped to a corresponding Envoy secret type.
Suggested-by: Yutaro Hayakawa yutaro.hayakawa@isovalent.com