-
Notifications
You must be signed in to change notification settings - Fork 3.4k
pkg/map/stats: provide Observable[T] fields for nat iteration. #35515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tommyp1ckles
merged 1 commit into
cilium:main
from
tommyp1ckles:pr/tp/observable-nat-stats
Nov 29, 2024
Merged
pkg/map/stats: provide Observable[T] fields for nat iteration. #35515
tommyp1ckles
merged 1 commit into
cilium:main
from
tommyp1ckles:pr/tp/observable-nat-stats
Nov 29, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d324909
to
5c65431
Compare
/test |
ysksuzuki
reviewed
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I've left some comments
5c65431
to
267b87a
Compare
/test |
/test |
ysksuzuki
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
267b87a
to
553fd89
Compare
/test |
553fd89
to
fc2727b
Compare
/test |
The data computed by nat-stats can be used by other cell modules to avoid having to do similar computations. To allow for safely exposing stream.Observable hooks, this abstracts accessing the nat tuple |-> count bucket map into a interface. Following computing the bucket count, observers can iterate the stats data by subscribing to the exported observable types in the nat-stats type. Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
fc2727b
to
5b40219
Compare
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data computed by nat-stats can be used by other cell modules to avoid having to do similar computations.
To allow for safely exposing stream.Observable hooks, this abstracts accessing the nat tuple |-> count bucket map into a interface.
Following computing the bucket count, observers can iterate the stats data by subscribing to the exported observable types in the nat-stats type.