Skip to content

Conversation

tommyp1ckles
Copy link
Contributor

@tommyp1ckles tommyp1ckles commented Oct 23, 2024

The data computed by nat-stats can be used by other cell modules to avoid having to do similar computations.

To allow for safely exposing stream.Observable hooks, this abstracts accessing the nat tuple |-> count bucket map into a interface.

Following computing the bucket count, observers can iterate the stats data by subscribing to the exported observable types in the nat-stats type.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 23, 2024
@tommyp1ckles tommyp1ckles force-pushed the pr/tp/observable-nat-stats branch from d324909 to 5c65431 Compare November 16, 2024 00:27
@tommyp1ckles
Copy link
Contributor Author

/test

@tommyp1ckles tommyp1ckles added the release-note/misc This PR makes changes that have no direct user impact. label Nov 16, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 16, 2024
@tommyp1ckles tommyp1ckles marked this pull request as ready for review November 16, 2024 00:28
@tommyp1ckles tommyp1ckles requested a review from a team as a code owner November 16, 2024 00:28
Copy link
Member

@ysksuzuki ysksuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I've left some comments

@tommyp1ckles tommyp1ckles force-pushed the pr/tp/observable-nat-stats branch from 5c65431 to 267b87a Compare November 22, 2024 23:30
@tommyp1ckles
Copy link
Contributor Author

/test

@tommyp1ckles
Copy link
Contributor Author

/test

Copy link
Member

@ysksuzuki ysksuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@tommyp1ckles tommyp1ckles force-pushed the pr/tp/observable-nat-stats branch from 267b87a to 553fd89 Compare November 26, 2024 04:28
@tommyp1ckles
Copy link
Contributor Author

/test

@tommyp1ckles tommyp1ckles force-pushed the pr/tp/observable-nat-stats branch from 553fd89 to fc2727b Compare November 27, 2024 21:16
@tommyp1ckles
Copy link
Contributor Author

/test

The data computed by nat-stats can be used by other cell modules
to avoid having to do similar computations.

To allow for safely exposing stream.Observable hooks, this abstracts
accessing the nat tuple |-> count bucket map into a interface.

Following computing the bucket count, observers can iterate the stats
data by subscribing to the exported observable types in the nat-stats
type.

Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
@tommyp1ckles tommyp1ckles force-pushed the pr/tp/observable-nat-stats branch from fc2727b to 5b40219 Compare November 28, 2024 01:02
@tommyp1ckles
Copy link
Contributor Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 29, 2024
@tommyp1ckles tommyp1ckles added this pull request to the merge queue Nov 29, 2024
Merged via the queue into cilium:main with commit 232e517 Nov 29, 2024
64 checks passed
@tommyp1ckles tommyp1ckles deleted the pr/tp/observable-nat-stats branch November 29, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants