ipcache: fix expensive conflict logging for frequently used prefixes #35511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rces This mirrors a real-world use-case where many policies reference the same CIDR. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
nathanjsweet
approved these changes
Oct 23, 2024
aadd577 to
c3f4600
Compare
|
/test |
Searching for conflicts when a given prefixes has a lot of resources is very expensive. Specifically, all resources must be sorted before checking for conflicts. Given that most resources do not set metadata that can conflict, this is not necessary. So, skip searching for conflicts if the supplied resource cannot cause a conflict. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
c3f4600 to
f95080c
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searching for conflicts when a given prefixes has a lot of resources is very expensive. Specifically, all resources must be sorted before checking for conflicts.
Given that most resources do not set metadata that can conflict, this is not necessary. So, skip searching for conflicts if the supplied resource cannot cause a conflict.